Skip to content

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Oct 21, 2024

No description provided.

@lforst lforst marked this pull request as ready for review October 21, 2024 09:22
@lforst lforst merged commit f358790 into develop Oct 21, 2024
123 checks passed
@lforst lforst deleted the lforst-fix-astro-cf-e2e branch October 21, 2024 09:24
Lms24 added a commit that referenced this pull request Dec 20, 2024
In our Astro-4 E2E test app, Astro's Node adapter was pinned to a bad
version that didn'T work correctly with newer Astro versions. We pinned
the Astro version a while ago in
#14030 to unblock CI
but looks like we just didn't follow up with investigating what caused
the issue back then.

This came up again when dependabot tried to bump the Astro version in
#14781 and #14807 and as a result #14808 was opened.

This PR now 
- bumps the Node adapter version which makes newer Astro version
function properly again
- updates `astro` to the latest v4 version (which is why I closed
#14807)

closes #14808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants